feat(airflow): improve setup script and add 1Password CLI integration #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Added - `set -eEuo pipefail` options for a more robust script. - Function `install_1pass_cli` to automate 1Password CLI installation for both Linux and macOS. - Function `login_1pass` to handle 1Password login processes. - Function `setup_airflow_variables_and_connections` to configure Airflow connections and variables using 1Password. - Interactive prompt to optionally set up Airflow variables and connections. - Logic to prevent multiple instances of Airflow standalone mode. ### Changed - Updated the description of S3 logging storage in `README.md` for production clarification. ### Fixed - Removed redundant environment variable exports and restructured script for clarity.
pietrodimarco-dfinity
approved these changes
Jan 23, 2025
NikolaMilosa
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
README Update: Clarifies that S3 Logging is for production Kubernetes deployments.
Script Enhancements:
set -eEuo pipefailfor more robust bash scripting.install_1pass_cli,login_1pass).User Interaction: Adds conditional prompt to setup Airflow variables and connections, optional for local runs.
Multi-functional Handling:
Command Execution: Updates execution to use defined utility paths.