Enhancements to release controller #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes https://dfinity.atlassian.net/browse/DRE-219 . Effectively, we skip changelog generation from Git for security hotfixes, replacing them with the text: > In accordance with the Security Patch Policy and Procedure that was adopted in proposal > 48792, the source code that was used to build this release will be exposed at the latest > 10 days after the fix is rolled out to all subnets. > > The community will be able to retroactively verify the binaries that were rolled out. The rest of the process remains identical.
The Mypy aspect is currently disabled.
…scovered using the dry run system.
1. Typing (not complete). 2. Functional change: check on start for existing election proposals, and save them in local database. 3. Functional change: do no work for versions and releases that have already been proposed.
…hing in Markdown must have changed with respect to quoting.
There was a problem hiding this comment.
Feels like we are trying everything we can to make python feel like something it isn't. How about we rewrite it in rust and the modules that we can't recreate we keep as python scripts?
This is just absurd amount of changes to review IMHO, I reviewed just bazel stuff
|
@NikolaMilosa I would be in favor of rewriting at least the reconciler in Rust. However, with these changes, it's far easier to work on the reconciler. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--skip-preloading-stateand a clean reconciler state store.--loop-every=0) and to adjust how often the reconciliation process shall loop.