-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tmp: Theme level variables #518
Draft
mstrasinskis
wants to merge
50
commits into
main
Choose a base branch
from
theme-level-variables
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into page-icon-colour
commit 1b6e6a7 Author: Max Strasinsky <[email protected]> Date: Wed Oct 30 17:46:06 2024 +0100 Update fixed icons
…ents into theme-level-variables # Conflicts: # replace-theme-vars.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
DO NOT MERGE!
Existing in old dark but not in new dark: Map(7) {
'box-shadow-color' => 'night-500',
'box-shadow-color-rgb' => '43, 51, 67',
'dropdown-focus-background' => 'night-575',
'dropdown-focus-border-color' => 'blue-accent',
'focus-background-tint' => 'night-400',
'table-background' => 'night-500',
'tag-text-dark' => 'night-550'
}
Existing in old light but not in new light: Map(7) {
'box-shadow-color' => 'night-500',
'box-shadow-color-rgb' => '111, 89, 133',
'dropdown-focus-background' => 'neutral-75',
'dropdown-focus-border-color' => 'blue-accent',
'focus-background-tint' => 'neutral-50',
'table-background' => 'neutral-75',
'tag-text-dark' => 'blue-900'
}
Existing in new components but not in old dark: Map(0) {}
Existing in new components but not in old light: Map(0) {}
Primitives that used in old Light theme, but not found in new (0): Map(0) {}
Primitives that used in old Dark theme, but not found in new (0): Map(0) {}
Light Theme New vs Old:
Themes have 82 same colors and 34 different:
Distance > 50%
tooltip-divider diff_rgb:73.52% diff_alpha:91.76% (from 3d3061$${\color{#3d3061}⏺}$$ to ffffff15 $${\color{#ffffff}⏺}$$ ) usage$${\color{#000000}⏺}$$ to ffffff45 $${\color{#ffffff}⏺}$$ ) usage$${\color{#ffffff}⏺}$$ to 151a33 $${\color{#151a33}⏺}$$ ) usage$${\color{#ffffff}⏺}$$ to 151a33 $${\color{#151a33}⏺}$$ ) usage
tooltip-border-color diff_rgb:100.00% diff_alpha:14.51% (from 00000020
backdrop-contrast diff_rgb:87.34% diff_alpha:0.00% (from ffffff
progress-color-contrast diff_rgb:87.34% diff_alpha:0.00% (from ffffff
Distance > 10%
theme-color diff_rgb:48.27% diff_alpha:0.00% (from 4d79ff$${\color{#4d79ff}⏺}$$ to f9f7ff $${\color{#f9f7ff}⏺}$$ ) usage$${\color{#ffffff}⏺}$$ to 6f7fcd $${\color{#6f7fcd}⏺}$$ ) usage$${\color{#b0a3d9}⏺}$$ to 3d4d99 $${\color{#3d4d99}⏺}$$ ) usage$${\color{#ab99d1}⏺}$$ to 3d4d99 $${\color{#3d4d99}⏺}$$ ) usage$${\color{#3d4d99}⏺}$$ to 4d79ff $${\color{#4d79ff}⏺}$$ ) usage$${\color{#3d4d99}⏺}$$ to 4d79ff $${\color{#4d79ff}⏺}$$ ) usage$${\color{#6f7fcd}⏺}$$ to 3d4d99 $${\color{#3d4d99}⏺}$$ ) usage$${\color{#6f7fcd}⏺}$$ to 3d4d99 $${\color{#3d4d99}⏺}$$ ) usage$${\color{#6f7fcd}⏺}$$ to 3d4d99 $${\color{#3d4d99}⏺}$$ ) usage$${\color{#0e0b26}⏺}$$ to 05070a80 $${\color{#05070a}⏺}$$ ) usage$${\color{#7c5cc2}⏺}$$ to 4d79ff $${\color{#4d79ff}⏺}$$ ) usage$${\color{#b0a3d9}⏺}$$ to dadef2 $${\color{#dadef2}⏺}$$ ) usage$${\color{#794ee7}⏺}$$ to 4d79ff $${\color{#4d79ff}⏺}$$ ) usage$${\color{#794ee7}⏺}$$ to 4d79ff $${\color{#4d79ff}⏺}$$ ) usage$${\color{#4b3bf8}⏺}$$ to 456de5 $${\color{#456de5}⏺}$$ ) usage$${\color{#382d50}⏺}$$ to 151a33 $${\color{#151a33}⏺}$$ ) usage$${\color{#382d50}⏺}$$ to 151a33 $${\color{#151a33}⏺}$$ ) usage$${\color{#382d50}⏺}$$ to 151a33 $${\color{#151a33}⏺}$$ ) usage
body-color diff_rgb:45.07% diff_alpha:0.00% (from ffffff
tertiary diff_rgb:35.60% diff_alpha:0.00% (from b0a3d9
disable-contrast-rgb diff_rgb:32.82% diff_alpha:0.00% (from 171, 153, 209
primary-tint diff_rgb:25.41% diff_alpha:0.00% (from 3d4d99
secondary diff_rgb:25.41% diff_alpha:0.00% (from 3d4d99
button-disable-color diff_rgb:19.87% diff_alpha:0.00% (from 6f7fcd
disable-contrast diff_rgb:19.87% diff_alpha:0.00% (from 6f7fcd
background-disable-contrast diff_rgb:19.87% diff_alpha:0.00% (from 6f7fcd
backdrop diff_rgb:6.72% diff_alpha:12.55% (from 0e0b2660
secondary-rgb diff_rgb:18.63% diff_alpha:0.00% (from 124, 92, 194
tooltip-description-color diff_rgb:17.35% diff_alpha:0.00% (from b0a3d9
progress-color-rgb diff_rgb:14.95% diff_alpha:0.00% (from 121, 78, 231
primary-rgb diff_rgb:14.95% diff_alpha:0.00% (from 121, 78, 231
primary-shade diff_rgb:12.19% diff_alpha:0.00% (from 4b3bf8
text-color-rgb diff_rgb:11.15% diff_alpha:0.00% (from 56, 45, 80
card-background-contrast-rgb diff_rgb:11.15% diff_alpha:0.00% (from 56, 45, 80
background-contrast-rgb diff_rgb:11.15% diff_alpha:0.00% (from 56, 45, 80
Distance < 10%
background-shade diff_rgb:9.49% diff_alpha:0.00% (from dadef2$${\color{#dadef2}⏺}$$ to f9f7ff $${\color{#f9f7ff}⏺}$$ ) usage$${\color{#dadef2}⏺}$$ to f9f7ff $${\color{#f9f7ff}⏺}$$ ) usage$${\color{#e1d9f3}⏺}$$ to f9f7ff $${\color{#f9f7ff}⏺}$$ ) usage$${\color{#eef1fe}⏺}$$ to ffffff $${\color{#ffffff}⏺}$$ ) usage$${\color{#130a2c}⏺}$$ to 151a33 $${\color{#151a33}⏺}$$ ) usage$${\color{#f8f6fc}⏺}$$ to ffffff $${\color{#ffffff}⏺}$$ ) usage$${\color{#30af91}⏺}$$ to 2db286 $${\color{#2db286}⏺}$$ ) usage$${\color{#f9f7ff}⏺}$$ to ffffff $${\color{#ffffff}⏺}$$ ) usage$${\color{#ffffff}⏺}$$ to f9f7ff $${\color{#f9f7ff}⏺}$$ ) usage$${\color{#ffffff}⏺}$$ to f9f7ff $${\color{#f9f7ff}⏺}$$ ) usage$${\color{#ffffff}⏺}$$ to f9f7ff $${\color{#f9f7ff}⏺}$$ ) usage$${\color{#f8f6fc}⏺}$$ to f9f7ff $${\color{#f9f7ff}⏺}$$ ) usage
background-disable diff_rgb:9.49% diff_alpha:0.00% (from dadef2
background-disable-rgb diff_rgb:9.11% diff_alpha:0.00% (from 225, 217, 243
disable diff_rgb:4.99% diff_alpha:0.00% (from eef1fe
tooltip-background diff_rgb:3.98% diff_alpha:0.00% (from 130a2c
focus-background-rgb diff_rgb:2.67% diff_alpha:0.00% (from 248, 246, 252
positive-emphasis-rgb diff_rgb:2.67% diff_alpha:0.00% (from 48, 175, 145
input-focus-background diff_rgb:2.26% diff_alpha:0.00% (from f9f7ff
button-card-focus-background diff_rgb:2.26% diff_alpha:0.00% (from ffffff
segment-selected-background diff_rgb:2.26% diff_alpha:0.00% (from ffffff
sidebar-button-background-hover diff_rgb:2.26% diff_alpha:0.00% (from ffffff
card-background-rgb diff_rgb:0.75% diff_alpha:0.00% (from 248, 246, 252
Dark Theme New vs Old:
Themes have 101 same colors and 15 different:
Distance > 50%
tooltip-divider diff_rgb:100.00% diff_alpha:87.45% (from ffffff$${\color{#ffffff}⏺}$$ to 00000020 $${\color{#000000}⏺}$$ ) usage$${\color{#f9f7ff}⏺}$$ to 2b3343 $${\color{#2b3343}⏺}$$ ) usage$${\color{#f9f7ff}⏺}$$ to 2b3343 $${\color{#2b3343}⏺}$$ ) usage
background-disable diff_rgb:77.18% diff_alpha:0.00% (from f9f7ff
background-disable-rgb diff_rgb:77.18% diff_alpha:0.00% (from 249, 247, 255
Distance > 10%
disable-contrast-rgb diff_rgb:16.99% diff_alpha:0.00% (from 155, 173, 209$${\color{#9badd1}⏺}$$ to 76839f $${\color{#76839f}⏺}$$ ) usage$${\color{#4d79ff}⏺}$$ to 906bff $${\color{#906bff}⏺}$$ ) usage$${\color{#4d79ff}⏺}$$ to 906bff $${\color{#906bff}⏺}$$ ) usage$${\color{#4d79ff}⏺}$$ to 906bff $${\color{#906bff}⏺}$$ ) usage$${\color{#1d222d}⏺}$$ to 323b4e $${\color{#323b4e}⏺}$$ ) usage
progress-color-rgb diff_rgb:15.50% diff_alpha:0.00% (from 77, 121, 255
primary-rgb diff_rgb:15.50% diff_alpha:0.00% (from 77, 121, 255
secondary-rgb diff_rgb:15.50% diff_alpha:0.00% (from 77, 121, 255
tooltip-description-color diff_rgb:10.51% diff_alpha:0.00% (from 1d222d
Distance < 10%
line diff_rgb:8.90% diff_alpha:0.00% (from 323b4e$${\color{#323b4e}⏺}$$ to 475266 $${\color{#475266}⏺}$$ ) usage$${\color{#323b4e}⏺}$$ to 212733 $${\color{#212733}⏺}$$ ) usage$${\color{#272f3d}⏺}$$ to 181c25 $${\color{#181c25}⏺}$$ ) usage$${\color{#272f3d}⏺}$$ to 181c25 $${\color{#181c25}⏺}$$ ) usage$${\color{#2b3343}⏺}$$ to 212733 $${\color{#212733}⏺}$$ ) usage$${\color{#323b4e}⏺}$$ to 2b3343 $${\color{#2b3343}⏺}$$ ) usage$${\color{#323b4e}⏺}$$ to 2b3343 $${\color{#2b3343}⏺}$$ ) usage
tag-background diff_rgb:8.53% diff_alpha:0.00% (from 323b4e
tooltip-text-color diff_rgb:7.72% diff_alpha:0.00% (from 272f3d
toast-inverted-background-contrast diff_rgb:7.72% diff_alpha:0.00% (from 272f3d
input-background diff_rgb:5.06% diff_alpha:0.00% (from 2b3343
overlay-content-background diff_rgb:3.46% diff_alpha:0.00% (from 323b4e
segment-selected-background diff_rgb:3.46% diff_alpha:0.00% (from 323b4e
Screenshots