Analyze theme variables #523
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I analyzed the
dark.scssandlight.scssfiles to get an idea of what theme variables we might need.A theme variable will have a value for dark and a different value for light and can be used by multiple components.
To understand which component variables might be able to use the same theme variable we need to know which component variables have the same value in both the light and the dark theme.
Additionally, variables that exist in only one of the themes or that have the same value in both themes, might not need a theme variable.
I changed the input files to make sure that each key/value pair is on a single line to make parsing easier.
Then I ran
node theme.js > output.textand added both to the branch.