feat: EXC-1787: Penalize canisters at the end of the round #2601
+32
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsarlis
approved these changes
Nov 15, 2024
The logic of penalizing canisters for full execution and distributing the priority across the subnet has been moved to the end of the round. This change is necessary for priority-based eviction. Newly created canisters join the first execution round with an accumulated priority of zero, which breaks two existing tests, but is not a practical issue. To compensate for this, during the reset round, we set the accumulated priority to the canister's compute allocation instead of the default zero priority.
berestovskyy
force-pushed
the
andriy/exc-1787-penalize-canisters-at-the-end
branch
from
b0732b1
to
39af462
Compare
berestovskyy
deleted the
andriy/exc-1787-penalize-canisters-at-the-end
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic of penalizing canisters for full execution and distributing the priority across the subnet has been moved to the end of the round. This change is necessary for priority-based eviction.
Newly created canisters join the first execution round with an accumulated priority of zero, which breaks two existing tests, but is not a practical issue. To compensate for this, during the reset round, we set the accumulated priority to the canister's compute allocation instead of the default zero priority.
There are also a few minor optimizations.