feat: [MR-353] Asynchronously mark checkpoint readonly and sync #3682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShuoWangNSL
force-pushed
the
shuo/async_ReadOnly_syncfs
branch
from
28432d3 to
756144d
Compare
ShuoWangNSL
force-pushed
the
shuo/async_ReadOnly_syncfs
branch
from
756144d to
c6bec38
Compare
ShuoWangNSL
changed the title
ShuoWangNSL
commented
Feb 5, 2025
ShuoWangNSL
force-pushed
the
shuo/async_ReadOnly_syncfs
branch
from
2eaf361 to
f014ac4
Compare
schneiderstefan
approved these changes
Feb 6, 2025
pakhomov-dfinity
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, during checkpointing, we block until we sync the entire checkpoint and have it moved to the checkpoints folder.
This step can be done asynchronously.
Moreover, due to the asynchronously writing of pbuf files, this step should be moved after that and right before removing the marker for unverified checkpoint.