fix: don't clone blocks during get_successors
#3687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihailjianu1
changed the title
get_successorsget_successors
eichhorl
approved these changes
Jan 31, 2025
| /// For each block hash, if the corresponding block is stored in the `block_cache`, the cached block is returned. | ||
| pub fn get_block(&self, block_hash: &BlockHash) -> Option<&Block> { | ||
| self.block_cache.get(block_hash) | ||
| /// This method takes a hash block |
There was a problem hiding this comment.
Suggested change
| /// This method takes a hash block | |
| /// This method takes a block hash. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before: blocks were cloned prior to being serialized and returned to the
get_successorscaller.After: an
Arcto the block is stored instead, and cloning doesn't happen (serialization does not need ownership).Block responses can get pretty large (~2MB), and cloning them take a long time. This is part of an effort to make the adapter able to process Testnet4 requests within the 50ms timeout from consensus.