-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(registry): Obsolete legacy ECDSA configs #3709
Conversation
ddf7002
to
29f7e20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this pull request affects the behavior of any canister owned by
the Governance team, remember to update the corresponding
unreleased_changes.md file(s).
To acknowldge this reminder (and unblock the PR), dismiss this
code review by going to the bottom of the pull request page, and
supply one of the following reasons:
-
Done.
-
No canister behavior changes.
This reverts commit b803bf0.
This PR is a follow-up to the chain-key config generalization worked that took place last year. Now that chain key has worked on the mainnet for a few months, the clients are ready, we simplify the API.
Notes on changed tests:
TODO[NNS1-3102]: Remove this test.
).test_disallow_chain_key_signing_disable_and_enable_for_same_key
andenable_and_disable_signing_lists_should_not_have_same_keys_in_single_request
)