feat(nns/sns): Add query stats to canister status #3710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonz-dfinity
force-pushed
the
jason/NNS1-3541-2
branch
2 times, most recently
from
3bc290e to
f340a67
Compare
jasonz-dfinity
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
If this pull request affects the behavior of any canister owned by
the Governance team, remember to update the corresponding
unreleased_changes.md file(s).
To acknowldge this reminder (and unblock the PR), dismiss this
code review by going to the bottom of the pull request page, and
supply one of the following reasons:
-
Done.
-
No canister behavior changes.
jasonz-dfinity
force-pushed
the
jason/NNS1-3541-2
branch
from
d17c2e3 to
19ce35d
Compare
max-dfinity
reviewed
Feb 4, 2025
max-dfinity
reviewed
Feb 4, 2025
max-dfinity
reviewed
Feb 4, 2025
jasonz-dfinity
force-pushed
the
jason/NNS1-3541-2
branch
from
d0674c8 to
38b4eca
Compare
max-dfinity
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The
query_statsfield from thecanister_statusmanagement canister API has been available for a while. Some NNS/SNS canisters expose methods to proxy the management canister method, and they haven't been updated to exposequery_statsyet.What
query_stats: QueryStatsFromManagementCanisterfor the management canister call. Nooptis needed since the management canister doesn't haveopt.query_stats: opt QueryStatsto theCanisterStatusResult/CanisterStatusResultV2structs, where each field inQueryStatsis alsoopt. This is consistent with other NNS/SNS APIs where we useoptto allow removing such fields if needed.Why the API change is safe
Since every addition in
*.didfiles changed by this PR isopt, decoding will always be successful no matter whether the sender/receiver of the message gets the change first.