-
Notifications
You must be signed in to change notification settings - Fork 43
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
style: extract global style to ensure build reproducibility (#1666)
# Motivation We have build reproducibility with last releases. CI: hash a2c0186 for https://github.com/dfinity/nns-dapp/actions/runs/3764587278 Local: hash 187a34a440503da62c161e679baa02b431455c17c2b6e51bc433d63dbcae2d8f Root cause of the issue is the build of the NNS-dapp frontend that generates different entries ("keys") in the ouputed `vite-manifest.json`. # Solution / Workaround The real solution still needs to be found but to fix the reproducibitility of current state we can avoid the use of CSS mixin in favor of a global style. If a global CSS style is used => a unique CSS is generated If mixins are used => Svelte or Vite tries to optimize the CSS and generate a single outputed CSS for the common code. In this process it generates a file and the algorithm uses the name of the first match. Therefore we ended up with a `vite-manifest.json` containing sometimes `SignInCanisters.css` or `SignInNeurons.css` # Changes - extract common CSS to global style # Screenshots ![image](https://user-images.githubusercontent.com/16886711/209373803-86f85300-6120-4730-9c59-a9e2f887ca25.png)
- Loading branch information
1 parent
a2c0186
commit b6305ad
Showing
5 changed files
with
16 additions
and
48 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
main.sign-in { | ||
display: flex; | ||
flex-direction: column; | ||
|
||
h1 { | ||
line-height: var(--line-height-standard); | ||
} | ||
|
||
p { | ||
margin-bottom: var(--padding-3x); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters