Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: adjust filter button height #4640

Merged
merged 3 commits into from
Mar 28, 2024
Merged

Conversation

mstrasinskis
Copy link
Contributor

@mstrasinskis mstrasinskis commented Mar 20, 2024

Motivation

Adjust the height of the filter buttons to ensure better alignment with the segment component. Since both components use button styles internally, simply removing any extra secondary styles should suffice to achieve uniform height.

Changes

  • remove button min-heigh (it shouldn't be so big here)
  • use negative margin to remove increased height from secondary button borders.

Tests

Manually
image

image

Todos

  • Add entry to changelog (if necessary).
    Not necessary.

@mstrasinskis mstrasinskis requested a review from a team as a code owner March 20, 2024 19:33
@mstrasinskis mstrasinskis requested a review from dskloetd March 20, 2024 19:35
@mstrasinskis mstrasinskis added this pull request to the merge queue Mar 28, 2024
Merged via the queue into main with commit 9b9a8c3 Mar 28, 2024
50 checks passed
@mstrasinskis mstrasinskis deleted the fix-filter-buttons-heigh branch March 28, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants