Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ic-js #4664

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Bump ic-js #4664

merged 2 commits into from
Mar 26, 2024

Conversation

dskloetd
Copy link
Contributor

@dskloetd dskloetd commented Mar 26, 2024

Motivation

Keep our ic-js dependency up to date.

In particular, we want to use the timestamp field that was added to the Transaction type of the index canister.

I attempted this with #4663 but had forgotten to publish the changes first.

Changes

  1. Ran npm run upgrade:next.
  2. Set the timestamp field on test values where it's required.

Tests

Still pass

Todos

  • Add entry to changelog (if necessary).
    not necessary

@dskloetd dskloetd marked this pull request as ready for review March 26, 2024 10:40
@dskloetd dskloetd requested a review from a team as a code owner March 26, 2024 10:40
@dskloetd dskloetd requested a review from mstrasinskis March 26, 2024 10:44
Copy link
Contributor

@mstrasinskis mstrasinskis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dskloetd dskloetd enabled auto-merge March 26, 2024 10:58
@dskloetd dskloetd added this pull request to the merge queue Mar 26, 2024
Merged via the queue into main with commit eb37b66 Mar 26, 2024
50 checks passed
@dskloetd dskloetd deleted the kloet/bump-timestamp branch March 26, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants