Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update IC candid files to release-2024-03-20_23-01-p2p #4666

Closed
wants to merge 1 commit into from
Closed

Update IC candid files to release-2024-03-20_23-01-p2p #4666

wants to merge 1 commit into from

Conversation

sa-github-api
Copy link
Collaborator

Motivation

A newer release of the internet computer is available.
Even with no changes, just updating the reference is good practice.

Changes

Changes made by a bot triggered by github-merge-queue

  • Update the version of ic specified in dfx.json.
  • Update the NNS candid files to the versions in that commit.

Tests

  • See CI
  • Check for breaking changes in the APIs and schedule any required follow-on work.

Breaking changes are:

  • New mandatory fields
    • Removing mandatory fields
    • Renaming fields
    • Changing the type of a field
    • Adding new variants

@sa-github-api sa-github-api requested a review from a team as a code owner March 27, 2024 07:32
@dskloetd dskloetd added this pull request to the merge queue Mar 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 27, 2024
@dskloetd dskloetd closed this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dskloetd dskloetd dskloetd approved these changes

@mstrasinskis mstrasinskis Awaiting requested review from mstrasinskis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sa-github-api @dskloetd @gix-bot