style: dropdown changes #4668
Merged
style: dropdown changes #4668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dskloetd
previously approved these changes
Mar 28, 2024
mstrasinskis
added a commit
to dfinity/gix-components
that referenced
this pull request
Mar 28, 2024
# Motivation `gix-components` changes for mobile project selector redesign. Part of dfinity/nns-dapp#4668 # Changes - `noMargin ` prop to remove margins from a `Card`. To avoid stretching of a `SplitContent` start block on mobile. - `--nav-component-title-display` css-variable to control the nav title to control it's visibility from outside. - don't display `SplitContent` start background on mobile. # Screenshots | Before | After | |--------|--------| | <img width="326" alt="image" src="https://github.com/dfinity/gix-components/assets/98811342/bf644db9-ae48-4ab1-a429-500ac6fa2f96"> | <img width="310" alt="image" src="https://github.com/dfinity/gix-components/assets/98811342/46c6e7ef-d428-46de-ac4a-3b932f8a3819"> | | --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
dskloetd
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Update style for project selector on mobile to provide more space for the content. A first step to the new split content design. Uses changes of
gix-componentpr - dfinity/gix-components#403Changes
npm run update:gixnoMarginBottomto remove bottom margins. To avoid stretching of a SplitContent start block on mobile.SplitContentcss values.Tests
Manually.
Todos
Screenshots
|