Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bot: Bump #5194

Closed
wants to merge 1 commit into from
Closed

bot: Bump #5194

wants to merge 1 commit into from

Conversation

sa-github-api
Copy link
Collaborator

Motivation

We want to pull in the latest changes.
We would like to render all the latest proposal types.
Even with no changes, just updating the reference is good practice.

Changes

  • Ran npm run update:gix
  • Ran `npm run upgrade:next

Tests

  • CI should pass
  • The pulled in changes should have been tested before being committed to their repositories.

@sa-github-api sa-github-api requested a review from a team as a code owner July 15, 2024 11:39
@dskloetd
Copy link
Contributor

Created for testing.

@dskloetd dskloetd closed this Jul 15, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jul 15, 2024
# Motivation

When making changes in gix-components or ic-js, we always need to pull
in the changes into nns-dapp.
This is very straightforwards and is kind of pointless to review.
If those changes can be made by a bot, only one person needs to review
it so nobody needs to be blocked.

# Changes

Add a workflow which can be used to automatically update gix-components
and/or ic-js.

# Tests

This PR was
[created](https://github.com/dfinity/nns-dapp/actions/runs/9938705200/job/27451714562)
with it: #5194
I just changed the PR title after doing that test.

# Todos

- [ ] Add entry to changelog (if necessary).
not necessary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants