Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NNS1-3094: Show banner when user never staked #5200

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Conversation

dskloetd
Copy link
Contributor

Motivation

To give the user extra information about staking if we know the user has never staked.

Changes

If neurons are loaded and we can tell the user has 0 neurons, show the same banner we show when the user is not signed in, but without the sign-in button.

Tests

  1. Unit tests added.
  2. Tested manually with anchor 10002 at https://qsgjb-riaaa-aaaaa-aaaga-cai.dskloet-ingress.devenv.dfinity.network/staking/

Todos

  • Add entry to changelog (if necessary).
    not yet

@dskloetd dskloetd marked this pull request as ready for review July 16, 2024 12:15
@dskloetd dskloetd requested a review from a team as a code owner July 16, 2024 12:15
@dskloetd dskloetd enabled auto-merge July 16, 2024 12:18
@dskloetd dskloetd added this pull request to the merge queue Jul 16, 2024
Merged via the queue into main with commit 99cc1eb Jul 16, 2024
40 checks passed
@dskloetd dskloetd deleted the kloet/staking-banner branch July 16, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants