Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(portfolio): implement page loading states #6216

Merged
merged 8 commits into from
Jan 23, 2025
Merged

feat(portfolio): implement page loading states #6216

merged 8 commits into from
Jan 23, 2025
+170 −11

Conversation

yhabib
Copy link
Contributor

@yhabib yhabib commented Jan 22, 2025 •
edited
Loading

Motivation

Loading all the information for the Portfolio page may take some time. We want to display loading indicators to enhance the user experience.

Screen.Recording.2025-01-22.at.13.04.12.mov

Changes

  • Logic to decide the type of card to display: empty, skeleton, or full, depending on the data.
  • Provide boolean to the total assets card if any content is loading.

Tests

  • Added unit test for the transition between not signed in, loading and loaded
  • Manually tested in devenv

Todos

  • Add entry to changelog (if necessary).
    Not necessary

@yhabib yhabib marked this pull request as ready for review January 22, 2025 12:05
@yhabib yhabib requested a review from a team as a code owner January 22, 2025 12:05
@yhabib yhabib requested a review from dskloetd January 22, 2025 15:25
@yhabib yhabib force-pushed the nns1-3538/portfolio-page-loading-states branch 2 times, most recently from bebb974 to 8c9c075 Compare January 22, 2025 16:12
@yhabib yhabib force-pushed the nns1-3538/portfolio-page-loading-states branch from 8c9c075 to db3c501 Compare January 23, 2025 07:13
dskloetd
dskloetd approved these changes Jan 23, 2025
View reviewed changes
frontend/src/lib/pages/Portfolio.svelte Show resolved Hide resolved
frontend/src/tests/lib/pages/Portfolio.spec.ts Outdated Show resolved Hide resolved
@yhabib yhabib enabled auto-merge January 23, 2025 08:31
@yhabib yhabib added this pull request to the merge queue Jan 23, 2025
Merged via the queue into main with commit 5d13f41 Jan 23, 2025
32 checks passed
@yhabib yhabib deleted the nns1-3538/portfolio-page-loading-states branch January 23, 2025 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dskloetd dskloetd dskloetd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yhabib @dskloetd