Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(navigation): implement contextual back navigation for Neuron's page #6345

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

yhabib
Copy link
Contributor

@yhabib yhabib commented Feb 4, 2025

Motivation

The Neuron's page has two potential entry points:

This PR follows up on #6343 by redirecting users from the Neuron's page based on their entry method.

Changes

  • Uses the new store neuronsPageOrigin to determine the navigation point when returning from the Neurons page.

Tests

  • Split the current test into a check button and a navigation check that returns to the Staking page.
  • Add a unit test to verify that navigation is correct when coming from the Portfolio page.

Todos

  • Add entry to changelog (if necessary).
    Not necessary

@yhabib yhabib changed the title feat(navigation): implement contextual back navigation for Neurons page feat(navigation): implement contextual back navigation for Neuron's page Feb 4, 2025
Base automatically changed from nns-3571/neurons-page-origin-store to main February 4, 2025 15:55
@yhabib yhabib marked this pull request as ready for review February 4, 2025 16:00
@yhabib yhabib requested a review from a team as a code owner February 4, 2025 16:00
@yhabib yhabib force-pushed the nns-3571/neurons-page-origin branch from 7b8d29b to a810ae0 Compare February 4, 2025 16:00
@yhabib yhabib added this pull request to the merge queue Feb 5, 2025
Merged via the queue into main with commit 5cd7d8b Feb 5, 2025
32 checks passed
@yhabib yhabib deleted the nns-3571/neurons-page-origin branch February 5, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants