Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PO for NnsProposalsFilterModal.spec.ts #6355

Merged
merged 6 commits into from
Feb 6, 2025
Merged

PO for NnsProposalsFilterModal.spec.ts #6355

merged 6 commits into from
Feb 6, 2025

Conversation

mstrasinskis
Copy link
Contributor

Motivation

Use PO in NnsProposalsFilterModal specs to streamline testing and simplify future changes.

Changes

  • Use FilterModalPo.

Tests

  • Yes

Todos

  • Add entry to changelog (if necessary).
    Not necessary.

@mstrasinskis mstrasinskis marked this pull request as ready for review February 5, 2025 22:05
@mstrasinskis mstrasinskis requested a review from a team as a code owner February 5, 2025 22:05
@mstrasinskis mstrasinskis requested a review from dskloetd February 6, 2025 08:32
@mstrasinskis mstrasinskis added this pull request to the merge queue Feb 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 6, 2025
@mstrasinskis mstrasinskis added this pull request to the merge queue Feb 6, 2025
Merged via the queue into main with commit 28621cd Feb 6, 2025
32 checks passed
@mstrasinskis mstrasinskis deleted the po-for-NnsProposalsFilterModal branch February 6, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dskloetd dskloetd dskloetd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mstrasinskis @dskloetd