Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Script to release beta on orbit #6360

Merged
merged 7 commits into from
Feb 6, 2025
Merged

Script to release beta on orbit #6360

merged 7 commits into from
Feb 6, 2025

Conversation

dskloetd
Copy link
Contributor

@dskloetd dskloetd commented Feb 6, 2025 •
edited
Loading

Motivation

We want to control to Beta NNS dapp canister with orbit for better security.

NOTE: beta.nns.ic0.app does not yet point to the canister managed by this script.

Changes

  1. Add a script which guides a team member through setting up their orbit environment and requesting the installation of nns-dapp on the orbit controlled canister.

Tests

  1. Tested manually together with @yhabib

Todos

  • Add entry to changelog (if necessary).
    not necessary

@dskloetd dskloetd marked this pull request as ready for review February 6, 2025 13:59
@dskloetd dskloetd requested a review from a team as a code owner February 6, 2025 13:59
@dskloetd dskloetd enabled auto-merge February 6, 2025 14:00
yhabib
yhabib approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@yhabib yhabib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks!

scripts/nns-dapp/release-beta Outdated Show resolved Hide resolved
scripts/nns-dapp/release-beta Outdated Show resolved Hide resolved
scripts/nns-dapp/release-beta Show resolved Hide resolved
dskloetd and others added 3 commits February 6, 2025 15:31
@dskloetd dskloetd added this pull request to the merge queue Feb 6, 2025
Merged via the queue into main with commit 1c1c84a Feb 6, 2025
32 checks passed
@dskloetd dskloetd deleted the kloet/release-beta branch February 6, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yhabib yhabib yhabib approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dskloetd @yhabib