Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update @dfinity/agent from 2.1.3 to 2.3.0 #6379

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Update @dfinity/agent from 2.1.3 to 2.3.0 #6379

merged 1 commit into from
Feb 10, 2025

Conversation

dskloetd
Copy link
Contributor

Motivation

  1. Keep our dependencies up to date.
  2. A bug in agent-js that caused invalid signatures on read_state retries was fixed.
  3. The new version supports better logging to investigate further invalid signature issues.

Changes

  1. Ran npm i @dfinity/agent@latest.

Tests

  1. Existing tests pass.
  2. Tested the extra logging in a separate branch.

Todos

  • Add entry to changelog (if necessary).
    not necessary

@dskloetd dskloetd marked this pull request as ready for review February 10, 2025 10:40
@dskloetd dskloetd requested a review from a team as a code owner February 10, 2025 10:40
@dskloetd dskloetd enabled auto-merge February 10, 2025 10:40
yhabib
yhabib approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@yhabib yhabib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@dskloetd dskloetd added this pull request to the merge queue Feb 10, 2025
Merged via the queue into main with commit df4f0db Feb 10, 2025
32 checks passed
@dskloetd dskloetd deleted the kloet/update-agent branch February 10, 2025 11:44
@dskloetd dskloetd mentioned this pull request Feb 11, 2025
Merged
1 task
github-merge-queue bot pushed a commit that referenced this pull request Feb 11, 2025
@dskloetd
Update @dfinity/principal, @dfinity/candid and @dfinity/auth-client (#…
1e6c071 
…6402)

# Motivation

In #6379 we updated
`@dfinity/agent` to 2.3.0.
`@dfinity/principal`, `@dfinity/candid` and `@dfinity/auth-client` are
all from the same repo and keep their versions in sync.
So it might be a good idea to update those to 2.3.0 as well.

One of these dependencies removed a dependency on `@peculiar/webcrypto`
but our tests still depend on it so it is now added as a test
dependency.

# Changes

1. Ran `npm i @dfinity/[email protected]`
2. Ran `npm i @dfinity/[email protected]`
3. Ran `npm i @dfinity/[email protected]`
4. Ran `npm i @peculiar/webcrypto -D`

# Tests

Pass

# Todos

- [ ] Add entry to changelog (if necessary).
not necessary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yhabib yhabib yhabib approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dskloetd @yhabib