Use fake timers in proposals.utils.spec.ts #6387
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I noticed flakiness in
frontend/src/tests/lib/utils/proposals.utils.spec.ts
which seemed to result from the test espectingnowInSeconds
to always return the same value during the test.Changes
vi.useFakeTimers()
inbeforeEach
infrontend/src/tests/lib/utils/proposals.utils.spec.ts
.Tests
Date.now
to always increase by 1 second on every call to see if any other tests had similar problems but this was the only test that failed.Todos
not necessary