Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tests): remove locally added screenshots from e2e tests #6388

Merged
merged 2 commits into from
Feb 10, 2025
Merged

fix(tests): remove locally added screenshots from e2e tests #6388

merged 2 commits into from
Feb 10, 2025

Conversation

yhabib
Copy link
Contributor

@yhabib yhabib commented Feb 10, 2025

Motivation

In #6369, I accidentally added two screenshots taken locally on the Mac. We should only include screenshots captured while running the e2e in the CI.

Changes

  • Removes screenshots.

Tests

  • Tests should pass as before

Todos

  • Add entry to changelog (if necessary).
    Not necessary

@yhabib yhabib marked this pull request as ready for review February 10, 2025 14:40
@yhabib yhabib requested a review from a team as a code owner February 10, 2025 14:40
@yhabib yhabib enabled auto-merge February 10, 2025 14:40
@yhabib yhabib added this pull request to the merge queue Feb 10, 2025
Merged via the queue into main with commit 7ba1881 Feb 10, 2025
32 checks passed
@yhabib yhabib deleted the yhabib/housekeeping/e2e-darwin branch February 10, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dskloetd dskloetd dskloetd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yhabib @dskloetd