Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bot: Update sns_aggregator candid bindings #6390

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

pr-automation-bot-public[bot]
Copy link
Contributor

Motivation

A newer release of the internet computer is available.
We would like to parse all the latest SNS data. To do so, we update the candid interfaces for the SNS aggregator.
Even with no changes, just updating the reference is good practice.

Changes

  • Update the version of IC_COMMIT_FOR_SNS_AGGREGATOR specified in config.json.
  • Updated the sns_aggregator candid files to the versions in that commit.
  • Updated the Rust code derived from .did files in the aggregator.

Tests

  • Please check the API updates for any breaking changes that affect our code.
    Breaking changes are:
    • New mandatory fields
    • Removing mandatory fields
    • Renaming fields
    • Changing the type of a field
    • Adding new variants

Copy link
Contributor

@yhabib yhabib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New response field, not a breaking changes

@yhabib yhabib added this pull request to the merge queue Feb 11, 2025
Merged via the queue into main with commit 08b030a Feb 11, 2025
32 checks passed
@yhabib yhabib deleted the bot-aggregator-update-1739245038 branch February 11, 2025 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants