chore(linting): update ESLint to latest minor version #6391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note, there was a flaky test that I'll investigate separately https://github.com/dfinity/nns-dapp/actions/runs/13257588019/job/37007239568?pr=6391 |
dskloetd
approved these changes
Feb 11, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
|
1 task
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 13, 2025
# Motivation In #6391, the merge queue failed due to a flaky test. The investigation revealed that the issue occurs when scrolling down to the button while the skeleton is present. At other times, the component loads, and the button moves out of the viewport, resulting in this strange behavior. # Changes - It waits for the component to render and for the skeleton to disappear before clicking. # Tests - Should pass as before. # Todos - [ ] Add entry to changelog (if necessary). Not necessary.
1 task
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 17, 2025
# Motivation We want to update ESLint to its latest version, as it is no longer supported. This follows up on #6391, and it is important because ESLint@8 is outdated.  To minimize the necessary changes due to the differences in how some rules apply now compared to before, I've overwritten certain rules. This will be addressed in a follow-up. # Changes - Upgrades ESLint and relevant packages to the latest version. - Installs new required packages. - Removes packages that are no longer needed. # Tests - Linting should pass as it did previously. # Todos - [ ] Add entry to changelog (if necessary). Not necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Eslint introduced a new version, @9, early last year. They will stop supporting our version later this year. The new version includes some breaking changes that require additional work. For now, I'm updating it to the latest minor version.
Changes
Tests
Todos
Not necessary