feat(frontend): validateConvertAmount util #3585
Conversation
| totalFee?: bigint; | ||
| }): ConvertAmountErrorType => { | ||
| if (isNullish(totalFee)) { | ||
| return; |
There was a problem hiding this comment.
I saw that in the code we do the same elsewhere, but I don't remember why? is it possible that the validation comes in another component when the fee is nullish?
There was a problem hiding this comment.
That's a good point. After thinking about it, I think it makes sense to validate insufficient-funds case even if totalFee is nullish. Therefore, I removed this check and adjusted the tests.
| return 'insufficient-funds'; | ||
| } | ||
|
|
||
| if (nonNullish(totalFee) && userAmount.add(totalFee).gt(parsedSendBalance)) { |
There was a problem hiding this comment.
theoretically here the nonNullish function is not needed, right? you already checked above
There was a problem hiding this comment.
ah, good catch, removing it!
There was a problem hiding this comment.
Doch - the check stays because of the comments above :)
|
@AntonioVentilii they are a few differences between them (mostly, in return types - one uses P.S.: a good moment to do it would be while migrating the Send flow to the new design. |
|
@AntonioVentilii ready for another look |
Motivation
The util that will be used in
ConvertAmountSourceascustomValidatefunction for the input. I extracted it from the component for the unit testing purposes.