feat(IDX): add internal-external workflow #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basvandijk
previously approved these changes
Jan 16, 2025
cgundy
dismissed
basvandijk’s stale review
Review dismissed by automation script.
nmattia
previously approved these changes
Jan 20, 2025
cla-idx-bot
bot
dismissed
nmattia’s stale review
Review dismissed by automation script.
marko-k0
previously approved these changes
Jan 20, 2025
basvandijk
previously approved these changes
Jan 20, 2025
github-actions
bot
dismissed
marko-k0’s stale review
Review dismissed by automation script.
github-actions
bot
dismissed stale reviews from basvandijk and nmattia
Review dismissed by automation script.
jwndlng
reviewed
Jan 23, 2025
jwndlng
approved these changes
Jan 23, 2025
marko-k0
reviewed
Jan 23, 2025
marko-k0
approved these changes
Jan 23, 2025
basvandijk
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of adding this workflow is to enable separate branch protection rules within the same repo. The logic works as follows:
for internal contributors: keep default level 2 branch protection rules -> with every new push reviews are kept and only one additional review (not by the commit author) is requiredfor external contributors: implement level 3 branch protection rules via this workflow -> with every new commit all PR reviews are cleared and the PR must be re-approved by all code ownersSee the diagram below for the workflow logic:
