-
Notifications
You must be signed in to change notification settings - Fork 7
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
# Motivation After using unique SNS names and logos, the new SNS demo images break the aggregator test because it's too much data to output all the stable memory as JSON. Having nice logos on CI isn't necessary. To reduce the size, we changed the scripts related to SNS creation to use a "logo.png" (which is 7816 bytes) image by default for all generated SNSes. # Changes - add `unique_logo` flag with false as default value. # Test - Tested manually by calling `dfx-snapshot-stock-make`, `dfx-sns-demo-mksns` and `dfx-sns-demo-mksns-config` scripts with different params. `dfx-snapshot-stock-make --snapshot ...` <img width="1519" alt="Screenshot 2024-07-05 at 12 39 28" src="https://github.com/dfinity/snsdemo/assets/98811342/ae5d68fe-c44c-4d29-a202-dae10984171b"> `dfx-snapshot-stock-make --unique_logo true --snapshot ...` <img width="1519" alt="image" src="https://github.com/dfinity/snsdemo/assets/98811342/96ef9f69-39a0-40ce-bac3-8b28f88442b0"> --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
- Loading branch information
1 parent
d8ce187
commit 13394e6
Showing
6 changed files
with
19 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters