Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework hybrid extra tag in SK-files #107

Merged
merged 1 commit into from
Jan 5, 2025

Conversation

vanderhe
Copy link
Member

@vanderhe vanderhe commented Jan 1, 2025

Drops all subtags, in favor of the general range-separated CAM case, as discussed. The regression test system now explicitly tests for the extra tag in the SK-files.

@vanderhe vanderhe marked this pull request as ready for review January 2, 2025 10:19
sktools/src/sktools/oldskfile.py Outdated Show resolved Hide resolved
sktools/src/sktools/oldskfile.py Outdated Show resolved Hide resolved
sktools/src/sktools/oldskfile.py Outdated Show resolved Hide resolved
@vanderhe vanderhe merged commit 5484d08 into dftbplus:main Jan 5, 2025
4 checks passed
@vanderhe vanderhe deleted the hybridExtraTag branch January 5, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants