fix(ci): always install playwright for FE builds

dgrebb · Mar 28, 2024 · 7d8a19e · 7d8a19e
1 parent d09ae0a
commit 7d8a19e
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/.github/actions/install-cache-deps/action.yml b/.github/actions/install-cache-deps/action.yml
@@ -49,15 +49,16 @@ runs:
         restore-keys: |
           ${{ runner.os }}-pnpm-store-
 
-    - name: 🎭 Install & Cache Playwright Binaries
-      if: ${{ inputs.BROWSER_BINARIES }}
+    - name: 🎭 Set Playwright Version
+      if: ${{ inputs.BROWSER_BINARIES == true || inputs.BROWSER_BINARIES == 'true' }}
       shell: bash
       working-directory: ${{ inputs.WORKSPACE_ROOT }}
       id: playwright-version
       run: echo 'PLAYWRIGHT_VERSION=$(cat package.json | jq -r '.dependencies.playwright' || 'latest')' >> $GITHUB_ENV
 
-    - uses: actions/cache@v4
-      if: ${{ inputs.BROWSER_BINARIES }}
+    - name: 🎭 Get Playwright Cache
+      uses: actions/cache@v4
+      if: ${{ inputs.BROWSER_BINARIES == true || inputs.BROWSER_BINARIES == 'true' }}
       id: playwright-cache
       with:
         path: |
@@ -66,7 +67,7 @@ runs:
 
     - name: Install and Cache Playwright
       shell: bash
-      if: ${{ inputs.BROWSER_BINARIES && steps.playwright-cache.outputs.cache-hit != 'true' }}
+      if: ${{ inputs.BROWSER_BINARIES == true || inputs.BROWSER_BINARIES == 'true' && steps.playwright-cache.outputs.cache-hit != 'true' }}
       working-directory: ${{ inputs.WORKSPACE_ROOT }}
       run: pnpx playwright install-deps
 

diff --git a/.github/workflows/bd-fe.yml b/.github/workflows/bd-fe.yml
@@ -100,6 +100,7 @@ jobs:
         uses: ./.github/actions/install-cache-deps
         with:
           WORKSPACE_ROOT: front
+          BROWSER_BINARIES: true
 
       - name: 🤿 Set Vars
         id: vars

diff --git a/_ci/backstop/package.json b/_ci/backstop/package.json
@@ -28,7 +28,6 @@
     "cors": "^2.8.5",
     "http-server": "^14.1.1",
     "patch-package": "^8.0.0",
-    "@playwright/test": "^1.41.2",
     "pm2": "^5.3.1",
     "super-simple-web-server": "github:dgrebb/super-simple-web-server#0.0.2"
   },