Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/post release 3.18.0 cleanup #1231

Merged
merged 4 commits into from
Feb 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/bdt-fe--release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,14 @@ jobs:
name: 💨
uses: ./.github/workflows/lint.yml
with:
env: ${{ inputs.env }}
env: ${{ github.event_name == 'push' && 'prd' || inputs.env }}

build_deploy:
name: 🚀
needs: lint
uses: ./.github/workflows/bd-fe.yml
with:
env: ${{ inputs.env }}
env: ${{ github.event_name == 'push' && 'prd' || inputs.env }}
secrets:
AWS_S3_BUCKET: ${{ secrets.AWS_S3_BUCKET }}
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
Expand Down Expand Up @@ -66,7 +66,7 @@ jobs:
needs: build_deploy
uses: ./.github/workflows/test-backstop.yml
with:
env: ${{ inputs.env }}
env: ${{ github.event_name == 'push' && 'prd' || inputs.env }}
secrets:
GH_WORKFLOW_TOKEN: ${{ secrets.GH_WORKFLOW_TOKEN }}
AWS_S3_BUCKET_REPORTS: ${{ secrets.AWS_S3_BUCKET_REPORTS }}
Expand All @@ -80,7 +80,7 @@ jobs:
needs: build_deploy
uses: ./.github/workflows/test-lighthouse.yml
with:
env: ${{ inputs.env }}
env: ${{ github.event_name == 'push' && 'prd' || inputs.env }}
secrets:
AWS_S3_BUCKET_REPORTS: ${{ secrets.AWS_S3_BUCKET_REPORTS }}
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
Expand All @@ -94,7 +94,7 @@ jobs:
needs: build_deploy
uses: ./.github/workflows/test-psi.yml
with:
env: ${{ inputs.env }}
env: ${{ github.event_name == 'push' && 'prd' || inputs.env }}
secrets:
PSI_APIKEY: ${{ secrets.PSI_APIKEY }}
GH_WORKFLOW_TOKEN: ${{ secrets.GH_WORKFLOW_TOKEN }}
Expand All @@ -104,7 +104,7 @@ jobs:
needs: [backstop, lighthouse, pagespeed]
runs-on: ubuntu-latest
environment:
name: ${{ inputs.env }}
name: ${{ github.event_name == 'push' && 'prd' || inputs.env }}
url: "https://${{ vars.WWW_DOMAIN }}"
steps:
- name: generate
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 4 additions & 0 deletions front/src/lib/components/content/parsers/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ import { marked } from 'marked';
import slugger from 'slugger';

/**
* @function
* @name parseTOC
* Parses the table of contents from markdown content.
*
* @param {string} contents - The markdown content.
Expand All @@ -24,6 +26,8 @@ export const parseTOC = function (contents) {
};

/**
* @function
* @name parseHighlightedLines
* Parses the highlighted lines string into an array of line numbers.
* Adjusts line numbers for zero-based indexing and sorts them in ascending order.
*
Expand Down
2 changes: 1 addition & 1 deletion front/src/lib/components/content/renderers/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -93,5 +93,5 @@ export const image = function (href, title, text) {
: '';
const imageTitle = title !== null ? `title="${title}"` : '';

return `<img src="${href}" src="${href}" alt="${cleanText}" ${imageTitle} class="post-image--${alignment}" />`;
return `<img src="${href}" src="${href}" alt="${cleanText}" ${imageTitle} loading="lazy" class="post-image--${alignment}" />`;
};
Loading