Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(front): ❤️ add assistive text to hero background image (#1234) #1236

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

dgrebb
Copy link
Owner

@dgrebb dgrebb commented Feb 14, 2024

Describe your changes

Uses alternativeText from CMS to add aria-label text to PostHero background image.

Issue ticket number and link

Closes: #1234

Checklist before requesting a review

  • Code linting succeeds
  • Visual Regression is Passing
  • I have performed a self-review of my code
  • Do we need to implement analytics?
  • Have you tested with JavaScript off?

@dgrebb dgrebb force-pushed the feat/1234-hero-alt-text branch from f7df07e to 0856312 Compare February 14, 2024 04:41
@dgrebb dgrebb changed the title feat(front): ❤️ add assistive text to hero background image (#1234) fix(front): ❤️ add assistive text to hero background image (#1234) Feb 14, 2024
@dgrebb dgrebb merged commit f305030 into develop Feb 14, 2024
8 checks passed
@dgrebb dgrebb deleted the feat/1234-hero-alt-text branch February 14, 2024 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

✨ [FEAT]: FE - Add aria-described-by and Strapi Media Library's Alt Text for Post Hero
1 participant