Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/post release 3.18.5 cleanup #1247

Merged
merged 5 commits into from
Feb 18, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -8,8 +8,8 @@

## Checklist before requesting a review

- [ ] Code linting succeeds
- [ ] Visual Regression is Passing
- [ ] I have performed a self-review of my code
- [ ] Do we need to implement analytics?
- [ ] Have you tested with JavaScript off?
- [x] Code linting succeeds
- [x] Visual Regression is Passing
- [x] I have performed a self-review of my code
- [x] Do we need to implement analytics?
- [x] Have you tested with JavaScript off?
26 changes: 19 additions & 7 deletions .github/workflows/PRs.yml
Original file line number Diff line number Diff line change
@@ -1,14 +1,26 @@
name: Assign PR
name: Assign and Review
run-name: "🦾 Reviewing ${{ github.event_name == 'pull_request' && format('PR #{0}: {1}', github.event.pull_request.number, github.event.pull_request.title) || format('latest {0}', github.ref_name) }}"

on:
pull_request_target:
types: [opened, reopened]
pull_request:
types: [opened, reopened, synchronize]

permissions:
pull-requests: write
permissions: write-all

jobs:
assign-author:
assign-and-review:
name: Assign and Review
runs-on: ubuntu-latest
steps:
- uses: toshimaru/[email protected]
- uses: grebbops/[email protected]
with:
repo-token: "${{ secrets.GITHUB_TOKEN }}"
- name: Checkout Repo
uses: actions/checkout@v4

- name: Review
uses: grebbops/ai-codereviewer@develop
with:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
exclude: ".github/**/*, **/*.json, **/*.md, _ci/backstop/bd/**/*"
2 changes: 1 addition & 1 deletion .github/workflows/bdt-fe--release.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: 🧑‍🚀 Build & Deploy Release
run-name: "🧑‍🚀 ${{ inputs.env == 'prd' && 'PRD' || 'STG' }} - Build, Deploy, and Test - ${{ github.event_name == 'pull_request' && format('PR #{0}: {1}', github.event.pull_request.number, github.event.pull_request.title) || format('latest {0}', github.ref_name) }}"
run-name: "🧑‍🚀 ${{ github.event_name == 'push' && 'PRD' || inputs.env == 'prd' && 'PRD' || 'STG' }} - Build, Deploy, and Test - ${{ github.event_name == 'pull_request' && format('PR #{0}: {1}', github.event.pull_request.number, github.event.pull_request.title) || format('latest {0}', github.ref_name) }}"

on:
workflow_dispatch:
3 changes: 2 additions & 1 deletion .github/workflows/bdt-fe.yml
Original file line number Diff line number Diff line change
@@ -3,6 +3,7 @@ run-name: "🚜 ${{ github.ref_name == 'main' && 'PRD' || 'STG' }} - Build, Depl

on:
workflow_dispatch:

pull_request:
paths:
- "front/**"
@@ -103,7 +104,7 @@ jobs:
needs: [backstop, lighthouse, pagespeed]
runs-on: ubuntu-latest
environment:
name: ${{ inputs.env }}
name: ${{ github.ref_name == 'main' && 'prd' || 'stg' }}
url: "https://${{ vars.WWW_DOMAIN }}"
steps:
- name: generate
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.