feat(backstop): use document-fonts-loaded branch of backstop and bump … #1286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgrebb
changed the title
Merged
dgrebb
added a commit
that referenced
this pull request
May 10, 2024
… … (#1286) …deps ## Describe your changes Uses a new branch for backstop, with changes to wait for `document.fonts.loaded` prior to capturing screen. ## Issue ticket number and link Uses new backstop branch to test font-load await. ## Checklist before requesting a review - [x] Code linting succeeds - [x] Visual Regression is Passing - [x] I have performed a self-review of my code - [x] Do we need to implement analytics? - [x] Have you tested with JavaScript off?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…deps
Describe your changes
Uses a new branch for backstop, with changes to wait for
document.fonts.loadedprior to capturing screen.Issue ticket number and link
Closes #1289
Checklist before requesting a review