Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with Hellfire items morphing when transferred to Diablo #7743

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

StephenCWills
Copy link
Member

Another issue introduced by the complicated hidden requirements of LoadMatchingItems(). The unpacked item must get the CF_HELLFIRE flag from the item regeneration logic instead of the dwBuff field from the packed data. Otherwise, LoadMatchingItems() won't be able to tell if it was unpacked as a Diablo item or a Hellfire item.

// Ensure that the unpacked item was regenerated using the appropriate
// game's item generation logic before attempting to use it for validation
if ((heroItem.dwBuff & CF_HELLFIRE) != (unpackedItem.dwBuff & CF_HELLFIRE)) {

This resolves #7742

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue Report]: Item Morphing
1 participant