Add Window class for Mac OS using AppleScript #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements the following: - get_foreground() class method - get_position() method - class_name property via the _get_class_name() method - executable property via the _get_window_module() method - title property via the _get_window_text() method
AppleScript is used by the DarwinWindow class.
This should allow app names and app bundle IDs to be used and makes the test suite pass again on Mac OS.
The method only returns a Window object for each foreground application because Mac OS doesn't have easily accessible unique identifiers for each window.
This also adds the full_screen(), get_attribute() and get_properties() methods.
This also mocks the 'applescript' module in documentation/conf.py.
|
I think is ready for merging now. All seems to be working for me on macOS 10.15. The One caveat with this class is that it is unable to differentiate between multiple windows belonging to the same application. Windows in macOS do have IDs, however they are tricky to use, are useless if you don't also have the app ID and don't really seem to be designed for use from other applications. I'm happy to review pull requests on fixing this or other problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #8, #35.
This is a work-in-progress
Windowclass implementation for Mac OS usingpy-applescript. It is based on Aenea's Mac OS server implementation (located here).