Support focusing windows without raising them on X11 #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The set_focus() method is an alias for the set_foreground() method on every platform except X11, where it focuses the target window, but does not raise it.
This optional argument allows focusing a matching window without raising it above other windows. The argument currently only does anything different on X11 (Linux). Windows and macOS don't seem to support this.
drmfinlay
added
Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
set_focus()methods for eachWindowclass and allows using it in theBringAppandFocusWindowactions via an optionalfocus_onlyargument (Falseby default). TheX11Windowclass has theset_focus()method since it was introduced (#102).set_focus()andfocus_onlyonly currently do anything different on X11 (Linux). Windows and macOS don't seem to support focusing windows without raising them, soset_focus()is just an alias forset_foreground()on those platforms.