feat(view): view hover style #1769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eat-hover-style
hiyuki
reviewed
Dec 24, 2024
| return enableAnimation | ||
| ? createElement(Animated.View, innerProps, childNode) | ||
| const BaseComponent = enableAnimation | ||
| ? createElement(Animated.View, extendObject({}, innerProps, { style: finalStyle }), childNode) |
hiyuki
reviewed
Dec 24, 2024
| @@ -610,3 +612,66 @@ export function pickStyle (styleObj: Record<string, any> = {}, pickedKeys: Array | |||
| return acc | |||
| }, {}) | |||
| } | |||
|
|
|||
| export function useHoverStyle ({ hoverStyle, hoverStartTime, hoverStayTime, disabled } : { hoverStyle?: ExtendedViewStyle, hoverStartTime: number, hoverStayTime: number, disabled?: boolean }) { | |||
nianxiongdi
force-pushed
the
feat-hover-style
branch
from
8c3d8b9 to
698f805
Compare
…eat-hover-style
hiyuki
reviewed
Jan 6, 2025
| const enableHoverStyle = !!hoverStyle | ||
| const enableHoverStyleRef = useRef(enableHoverStyle) | ||
| if (enableHoverStyleRef.current !== enableHoverStyle) { | ||
| throw new Error('[Mpx runtime error]: hover-class use should be stable in the component lifecycle.') |
hiyuki
reviewed
Jan 6, 2025
| throw new Error('[Mpx runtime error]: hover-class use should be stable in the component lifecycle.') | ||
| } | ||
|
|
||
| if (!enableHoverStyle) return { enableHoverStyle } |
There was a problem hiding this comment.
用enableHoverStyleRef.current来判断
hiyuki
reviewed
Jan 6, 2025
| error('[Mpx runtime error]: animation use should be stable in the component lifecycle, or you can set [enable-animation] with true.') | ||
| } | ||
|
|
||
| if (!enableStyleAnimation) return { enableStyleAnimation } |
There was a problem hiding this comment.
用enableAnimationRef.current来判断
hiyuki
reviewed
Jan 6, 2025
| if (disabled) return | ||
| runOnJS(setStayTimer)() | ||
| }) | ||
| }, [disabled]) |
hiyuki
reviewed
Jan 6, 2025
| return Gesture.Pan() | ||
| .onTouchesDown(() => { | ||
| 'worklet' | ||
| if (disabled) return |
hiyuki
reviewed
Jan 6, 2025
| } = props | ||
|
|
||
| const pageId = useContext(RouteContext) | ||
|
|
||
| const formContext = useContext(FormContext) | ||
|
|
||
| const { isHover, enableHoverStyle, gesture } = useHoverStyle({ hoverStyle, hoverStartTime, hoverStayTime, disabled }) |
There was a problem hiding this comment.
enableHoverStyle可以在外部决定，对于button来说只要hoverClass不为none就是true，另外简写为enableHover就行
added 2 commits
January 9, 2025 15:55
hiyuki
reviewed
Jan 9, 2025
| error('[Mpx runtime error]: animation use should be stable in the component lifecycle, or you can set [enable-animation] with true.') | ||
| } | ||
|
|
||
| if (!enableAnimationRef.current) return { animationStyle: false } |
There was a problem hiding this comment.
这里应该返回enableStyleAnimation:false
hiyuki
reviewed
Jan 9, 2025
| @@ -642,3 +644,64 @@ export function pickStyle (styleObj: Record<string, any> = {}, pickedKeys: Array | |||
| return acc | |||
| }, {}) | |||
| } | |||
|
|
|||
| export function useHoverStyle ({ enableHover, hoverStartTime, hoverStayTime, disabled } : { enableHover: boolean, hoverStartTime: number, hoverStayTime: number, disabled?: boolean }) { | |||
hiyuki
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.