Improve CompatibleType not implemented error message #4472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was told "OK I see this error message but my struct already implements Selectable so that's not useful". As it turns out, this message would sometimes be misunderstood as the `check_for_backend` part only relating to the `QueryableByName` usage, but not to the `Selectable` usage, whereas that is in fact the key point. Hopefully this new writing will avoid this. :)
Ten0
changed the title
Ten0
changed the title
JohnTitor
approved these changes
Feb 8, 2025
weiznich
reviewed
Feb 8, 2025
There was a problem hiding this comment.
Looks good for me beside the missing ` to indicate that this is rust code. It just looks strange to use them only partially.
That written: Ideally I would find the time to implement the other part of the on_unimplemented attribute, which would allow us to add conditions to that attribute to only apply in certain situations. That would enable us to only talk about Selectable or QueryableByName if they are relevant. Maybe someday…
Co-authored-by: Georg Semmler <[email protected]>
Ten0
force-pushed
the
improve_compatibletype_error_message
branch
from
8d895fe to
0813d76
Compare
weiznich
added
the
maybe backport
weiznich
added a commit
to weiznich/diesel
that referenced
this pull request
Feb 14, 2025
This commit prepares a 2.2.8 release that includes the following changes: * diesel-rs#4472 * diesel-rs#4484 * diesel-rs#4486 * diesel-rs#4480
weiznich
added a commit
to weiznich/diesel
that referenced
this pull request
Feb 14, 2025
This commit prepares a 2.2.8 release that includes the following changes: * diesel-rs#4472 * diesel-rs#4484 * diesel-rs#4486 * diesel-rs#4480
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was told "OK I see this error message but my struct already implements Selectable so that's not useful".
As it turns out, this message would sometimes be misunderstood as the
check_for_backendpart only relating to theQueryableByNameusage, but not to theSelectableusage, whereascheck_for_backendis in fact the key point.Hopefully this new writing will avoid this. :)