Clear up a bunch of unnecessary clones in diesel_cli config parsing #4513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ten0
added a commit
to sgoll/diesel
that referenced
this pull request
Mar 3, 2025
Actually a lot of other places in here have the same issue. Fixing this will be tracked by diesel-rs#4513.
Ten0
force-pushed
the
fix_unnecessary_clones_in_diesel_cli_config_parsing
branch
from
34ca931 to
bfb177b
Compare
Ten0
force-pushed
the
fix_unnecessary_clones_in_diesel_cli_config_parsing
branch
from
bfb177b to
a59055d
Compare
Ten0
force-pushed
the
fix_unnecessary_clones_in_diesel_cli_config_parsing
branch
from
a59055d to
05c58f8
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 4, 2025
Actually a lot of other places in here have the same issue. Fixing this will be tracked by #4513.
weiznich
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed upon reviewing #4500 that there were similar unnecessary clones all throughout the file.
I went and cleaned them up but it ended up making for enough changes that I felt it deserved to be in a separate PR.
This PR should have no behavioral change.