chore: overhaul project setup #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #32
Closes #35
Non-exhaustive summary of changes:
Avoid using Forge's Vite plugin and instead create our own plugin that's tailored to our needs. We still use Vite for bundling the renderer code but otherwise, we rely on Electron's ESM support for main process code, and do no special processing for preload code.
Introduce basic CI
More thorough Forge configuration for app packaging
upgrades all deps
more exhaustive formatting + linting setup
improvements to npm scripts setup
Notable improvements to be made as follow-ups:
proper ingestion of env files/variables
proper error handling for root key loading
unification of vite + forge when working in development