chore: integrate testing #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achou11
requested changes
Dec 11, 2024
Comment on lines
+227
to
+229
| export function getUtf8ByteLength(text: string): number { | ||
| return new TextEncoder().encode(text).length | ||
| } |
There was a problem hiding this comment.
maybe outside the scope of this PR but would eventually move this to something likerenderer/lib/text.ts
Comment on lines
+6
to
+15
| vi.mock('@tanstack/react-router', () => ({ | ||
| useNavigate: vi.fn(() => { | ||
| return { navigate: vi.fn() } | ||
| }), | ||
| createFileRoute: vi.fn(() => { | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| return (options: any) => ({ component: options.component }) // Mocked implementation | ||
| }), | ||
| Outlet: () => <div>Mocked Outlet</div>, | ||
| })) |
There was a problem hiding this comment.
just for my understanding, this has to be done for each test that relies on the router in some way?
There was a problem hiding this comment.
it depends. I think short answer yes. long answer, if we want to test actual navigation actions, we need to stub out the router instead of just stubbing out the function inside the router.
I think more work needs to go into creating our mocks and stubs, but this just allows it run (its was basically a smoke screen test for jsdom)
achou11
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets up vitetest and React Testing Library