-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: integrate map libre #61
Conversation
…kers don't exist by default in a test environment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert the renaming of this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops
scrollZoom={true} | ||
doubleClickZoom={true} | ||
style={{ width: '100%', height: '100%' }} | ||
mapStyle="https://demotiles.maplibre.org/style.json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for posterity: although I initially suggested using the hook here, it turns out that MapLibre dropped support for mapbox://
urls, which our default online style currently contains. there's a way of fixing that by using https://github.com/rowanwins/maplibregl-mapbox-request-transformer but it requires the renderer needing access to the the access token, which isn't ideal and probably prone to breaking under other circumstances. Will file an issue to fix the mapbox-specific urls in core but for now, i think it's okay to use the MapLibre demotiles url for the mapStyle
, like you were doing before.
added an issue in core for this: digidem/comapeo-core#982
…ixes naming of patch package.
closes #43