Update rules_nixpgks to HEAD and drop rules-nixpkgs-arm.patch
#13798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbley-da
force-pushed
the
update-rules_nixpkgs
branch
4 times, most recently
from
2b0abfe to
f7b7438
Compare
Since [rules_nixpkgs#191] has been merged, we can drop the `rules-nixpkgs-arm.patch` from rules_nixpkgs. Also, rules_nixpkgs has been split into several components which need to be added explicitly in `deps.bzl`, see [#182]. [#191]: tweag/rules_nixpkgs#191 [#182]: tweag/rules_nixpkgs#182
It has been updated in rules_nixpkgs, so this just follows suite.
In rules_nixpkgs, this attribute is now used to determine whether the compiler is clang, see [#216]. [#216]: tweag/rules_nixpkgs#216 CHANGELOG_BEGIN CHANGELOG_END
cbley-da
force-pushed
the
update-rules_nixpkgs
branch
from
f7b7438 to
b2c9f47
Compare
cbley-da
changed the title
rules_nixpgks to HEADrules_nixpgks to HEAD and drop rules-nixpkgs-arm.patch
Happy to drop more patches. There shouldn't be any reason why we need to support old nixes as far as I'm aware. But please do that as a separate PR, as that seems unrelated to this change here. |
Please see #13820 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Drop the
rules-nixpkgs-arm.patchfrom the rules_nixpkgs repository, since its changes have been brought upstream in rules_nixpkgs#191.Changes
rules-nixpkgs-arm.patchrules_nixpkgsand load components explicitly (see Split rules_nixpkgs into separate components tweag/rules_nixpkgs#182)isClangcheckQuestion ❓
While we are at it, I really would like to drop the
@com_github_digital_asset_daml//bazel_tools:nixpkgs-disable-http2.patchfrom rules_nixpkgs, too. This works around a problem that was seen with old nix versions and was fixed with nix 2.3.3 (NixOS/nix#2733 (comment))Is it still feasible to maintain backward compatibility with nix < 2.3.3?
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.