Fail to start if any rados connection fails on startup #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not instantiating an exporter and logging instead of failing to start when we can't connect to one of the configured clusters is not the behaviour we want; a user may think that ceph_exporter is monitoring all of the requested clusters (since it's up and responds to metrics requests) when in fact data is missing.
Matt1360
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not instantiating an exporter and logging instead of failing to start when we can't connect to one of the configured clusters is not the behaviour we want; a user may think that ceph_exporter is monitoring all of the requested clusters (since it's up and responds to metrics requests) when in fact data is missing.