forked from hootsuite/pre-commit-php
-
Notifications
You must be signed in to change notification settings - Fork 37
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
0 parents
commit 58a4a7c
Showing
8 changed files
with
372 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
# Pre-commit | ||
# @see http://pre-commit.com/ | ||
- repo: git://github.com/pre-commit/pre-commit-hooks | ||
sha: master | ||
hooks: | ||
- id: check-yaml | ||
files: \.(yaml|yml)$ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
# Change Log | ||
|
||
All notable changes will be documented in this file. Guidelines on the format and styleguide for this changelog can be found [here](http://keepachangelog.com/) | ||
|
||
Version names based on [Top 100 Songs of 1984 - Billboard Year End Charts](http://www.bobborst.com/popculture/top-100-songs-of-the-year/?year=1984), follow in descending order. | ||
|
||
## 1.0.0 - 2015-03-03 - `Footloose` | ||
|
||
Initial Public Release. Version number bumped and moved out of the private repository. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
Apache License | ||
|
||
Version 2.0, January 2004 | ||
|
||
http://www.apache.org/licenses/ | ||
|
||
TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION | ||
|
||
1. Definitions. | ||
|
||
"License" shall mean the terms and conditions for use, reproduction, and distribution as defined by Sections 1 through 9 of this document. | ||
|
||
"Licensor" shall mean the copyright owner or entity authorized by the copyright owner that is granting the License. | ||
|
||
"Legal Entity" shall mean the union of the acting entity and all other entities that control, are controlled by, or are under common control with that entity. For the purposes of this definition, "control" means (i) the power, direct or indirect, to cause the direction or management of such entity, whether by contract or otherwise, or (ii) ownership of fifty percent (50%) or more of the outstanding shares, or (iii) beneficial ownership of such entity. | ||
|
||
"You" (or "Your") shall mean an individual or Legal Entity exercising permissions granted by this License. | ||
|
||
"Source" form shall mean the preferred form for making modifications, including but not limited to software source code, documentation source, and configuration files. | ||
|
||
"Object" form shall mean any form resulting from mechanical transformation or translation of a Source form, including but not limited to compiled object code, generated documentation, and conversions to other media types. | ||
|
||
"Work" shall mean the work of authorship, whether in Source or Object form, made available under the License, as indicated by a copyright notice that is included in or attached to the work (an example is provided in the Appendix below). | ||
|
||
"Derivative Works" shall mean any work, whether in Source or Object form, that is based on (or derived from) the Work and for which the editorial revisions, annotations, elaborations, or other modifications represent, as a whole, an original work of authorship. For the purposes of this License, Derivative Works shall not include works that remain separable from, or merely link (or bind by name) to the interfaces of, the Work and Derivative Works thereof. | ||
|
||
"Contribution" shall mean any work of authorship, including the original version of the Work and any modifications or additions to that Work or Derivative Works thereof, that is intentionally submitted to Licensor for inclusion in the Work by the copyright owner or by an individual or Legal Entity authorized to submit on behalf of the copyright owner. For the purposes of this definition, "submitted" means any form of electronic, verbal, or written communication sent to the Licensor or its representatives, including but not limited to communication on electronic mailing lists, source code control systems, and issue tracking systems that are managed by, or on behalf of, the Licensor for the purpose of discussing and improving the Work, but excluding communication that is conspicuously marked or otherwise designated in writing by the copyright owner as "Not a Contribution." | ||
|
||
"Contributor" shall mean Licensor and any individual or Legal Entity on behalf of whom a Contribution has been received by Licensor and subsequently incorporated within the Work. | ||
|
||
2. Grant of Copyright License. Subject to the terms and conditions of this License, each Contributor hereby grants to You a perpetual, worldwide, non-exclusive, no-charge, royalty-free, irrevocable copyright license to reproduce, prepare Derivative Works of, publicly display, publicly perform, sublicense, and distribute the Work and such Derivative Works in Source or Object form. | ||
|
||
3. Grant of Patent License. Subject to the terms and conditions of this License, each Contributor hereby grants to You a perpetual, worldwide, non-exclusive, no-charge, royalty-free, irrevocable (except as stated in this section) patent license to make, have made, use, offer to sell, sell, import, and otherwise transfer the Work, where such license applies only to those patent claims licensable by such Contributor that are necessarily infringed by their Contribution(s) alone or by combination of their Contribution(s) with the Work to which such Contribution(s) was submitted. If You institute patent litigation against any entity (including a cross-claim or counterclaim in a lawsuit) alleging that the Work or a Contribution incorporated within the Work constitutes direct or contributory patent infringement, then any patent licenses granted to You under this License for that Work shall terminate as of the date such litigation is filed. | ||
|
||
4. Redistribution. You may reproduce and distribute copies of the Work or Derivative Works thereof in any medium, with or without modifications, and in Source or Object form, provided that You meet the following conditions: | ||
|
||
You must give any other recipients of the Work or Derivative Works a copy of this License; and | ||
You must cause any modified files to carry prominent notices stating that You changed the files; and | ||
You must retain, in the Source form of any Derivative Works that You distribute, all copyright, patent, trademark, and attribution notices from the Source form of the Work, excluding those notices that do not pertain to any part of the Derivative Works; and | ||
If the Work includes a "NOTICE" text file as part of its distribution, then any Derivative Works that You distribute must include a readable copy of the attribution notices contained within such NOTICE file, excluding those notices that do not pertain to any part of the Derivative Works, in at least one of the following places: within a NOTICE text file distributed as part of the Derivative Works; within the Source form or documentation, if provided along with the Derivative Works; or, within a display generated by the Derivative Works, if and wherever such third-party notices normally appear. The contents of the NOTICE file are for informational purposes only and do not modify the License. You may add Your own attribution notices within Derivative Works that You distribute, alongside or as an addendum to the NOTICE text from the Work, provided that such additional attribution notices cannot be construed as modifying the License. | ||
|
||
You may add Your own copyright statement to Your modifications and may provide additional or different license terms and conditions for use, reproduction, or distribution of Your modifications, or for any such Derivative Works as a whole, provided Your use, reproduction, and distribution of the Work otherwise complies with the conditions stated in this License. | ||
5. Submission of Contributions. Unless You explicitly state otherwise, any Contribution intentionally submitted for inclusion in the Work by You to the Licensor shall be under the terms and conditions of this License, without any additional terms or conditions. Notwithstanding the above, nothing herein shall supersede or modify the terms of any separate license agreement you may have executed with Licensor regarding such Contributions. | ||
|
||
6. Trademarks. This License does not grant permission to use the trade names, trademarks, service marks, or product names of the Licensor, except as required for reasonable and customary use in describing the origin of the Work and reproducing the content of the NOTICE file. | ||
|
||
7. Disclaimer of Warranty. Unless required by applicable law or agreed to in writing, Licensor provides the Work (and each Contributor provides its Contributions) on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied, including, without limitation, any warranties or conditions of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A PARTICULAR PURPOSE. You are solely responsible for determining the appropriateness of using or redistributing the Work and assume any risks associated with Your exercise of permissions under this License. | ||
|
||
8. Limitation of Liability. In no event and under no legal theory, whether in tort (including negligence), contract, or otherwise, unless required by applicable law (such as deliberate and grossly negligent acts) or agreed to in writing, shall any Contributor be liable to You for damages, including any direct, indirect, special, incidental, or consequential damages of any character arising as a result of this License or out of the use or inability to use the Work (including but not limited to damages for loss of goodwill, work stoppage, computer failure or malfunction, or any and all other commercial damages or losses), even if such Contributor has been advised of the possibility of such damages. | ||
|
||
9. Accepting Warranty or Additional Liability. While redistributing the Work or Derivative Works thereof, You may choose to offer, and charge a fee for, acceptance of support, warranty, indemnity, or other liability obligations and/or rights consistent with this License. However, in accepting such obligations, You may act only on Your own behalf and on Your sole responsibility, not on behalf of any other Contributor, and only if You agree to indemnify, defend, and hold each Contributor harmless for any liability incurred by, or claims asserted against, such Contributor by reason of your accepting any such warranty or additional liability. | ||
|
||
END OF TERMS AND CONDITIONS |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,88 @@ | ||
# Hootsuite Campaigns - PHP Pre-commit Hooks | ||
|
||
Pre-commit scripts appropiate for *any* PHP project. These hooks are made as custom plugins under the [pre-commit](http://pre-commit.com/#new-hooks) git hook framework. | ||
|
||
# Setup | ||
|
||
Just add to your `.pre-commit-config.yaml` file with the following | ||
|
||
```yaml | ||
- repo: [email protected]/hootsuite/pre-commit-php.git | ||
sha: 1.0.0 | ||
hooks: | ||
- id: php-lint | ||
- id: php-unit | ||
- id: php-cs | ||
files: \.(php)$ | ||
args: [--standard=PSR1 -p] | ||
``` | ||
# Supported Hooks | ||
## php-lint | ||
```yaml | ||
- repo: [email protected]/hootsuite/pre-commit-php.git | ||
sha: 1.0.0 | ||
hooks: | ||
- id: php-lint | ||
``` | ||
A bash script that runs `php -l` against stage files that are php. Assumes `php` is a global executable command. Will exit when it hits the first syntax error. | ||
|
||
## php-lint-all | ||
|
||
```yaml | ||
- repo: [email protected]/hootsuite/pre-commit-php.git | ||
sha: 1.0.0 | ||
hooks: | ||
- id: php-lint-all | ||
``` | ||
|
||
A systems hook that just runs `php -l` against stage files that have the `.php` extension. Add the `args: [-s first]` in your `.pre-commit-config.yaml` to enable it to exit on the first error found. | ||
|
||
## php-unit | ||
|
||
|
||
```yaml | ||
- repo: [email protected]/hootsuite/pre-commit-php.git | ||
sha: 1.0.0 | ||
hooks: | ||
- id: php-unit | ||
``` | ||
|
||
A bash script that will run the appropriate phpunit executable. It will assume | ||
- Find the executable to run at either `vendor/bin/phpunit`, `phpunit` or `php phpunit.phar` (in that exact order). | ||
- There is already a `phpunit.xml` in the root of the repo | ||
|
||
Note in its current state, it will run the whole PHPUnit test as along as `.php` file was committed. | ||
|
||
## php-cs | ||
|
||
```yaml | ||
- repo: [email protected]/hootsuite/pre-commit-php.git | ||
sha: 1.0.0 | ||
hooks: | ||
- id: php-cs | ||
files: \.(php)$ | ||
args: [--standard=PSR1 -p] | ||
``` | ||
|
||
Similar pattern as the php-unit hook. A bash script that will run the appropriate [PHP Code Sniffer](https://github.com/squizlabs/PHP_CodeSniffer) executable. | ||
|
||
It will assume that there is a valid PHP Code Sniffer executable at these locations, `vendor/bin/phpcs`, `phpcs` or `php phpcs.phar` (in that exact order). | ||
|
||
The `args` property in your hook declaration can be used for pass any valid PHP Code Sniffer arguments. In the example above, it will run PHP Code Sniffer against only the staged php files with the `PSR-1` and progress enabled. | ||
|
||
If you have multiple standards or a comma in your `args` property, escape the comma character like so | ||
|
||
```yaml | ||
- repo: [email protected]/hootsuite/pre-commit-php.git | ||
sha: 1.0.0 | ||
hooks: | ||
- id: php-cs | ||
files: \.(php)$ | ||
args: [--standard=PSR1/,path/to/ruleset.xml -p] | ||
``` | ||
|
||
To install PHP Codesniffer, follow the [recommended steps here](https://github.com/squizlabs/PHP_CodeSniffer#installation). |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
- id: php-lint-all | ||
name: PHP Syntax Check (Comprehensive) | ||
description: Check PHP Syntax on ALL PHP staged files with user friendly messages and colors | ||
entry: pre_commit_hooks/php-lint.sh | ||
language: script | ||
files: \.php$ | ||
args: [-s all] | ||
|
||
- id: php-lint | ||
name: PHP Syntax Check (Quick) | ||
description: Runs php -l on all staged files. Exits when it hits the first errored file | ||
entry: php -l | ||
language: system | ||
files: \.php$ | ||
|
||
- id: php-unit | ||
name: PHP Unit | ||
description: Run the full php unit test. Checks which PHPUnit executable is available first and then runs it. Preference order is vendor/bin, phpunit and phpunit.phar. | ||
entry: pre_commit_hooks/php-unit.sh | ||
language: script | ||
files: \.php$ | ||
|
||
- id: php-cs | ||
name: PHP Codesniffer | ||
description: Run php codesniffer against all staged files. | ||
entry: pre_commit_hooks/php-cs.sh | ||
language: script | ||
files: \.php$ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
#!/bin/bash | ||
|
||
# Bash PHP Codesniffer Hook | ||
# This script fails if the PHP Codesniffer output has the word "ERROR" in it. | ||
# Does not support failing on WARNING AND ERROR at the same time. | ||
# | ||
# Exit 0 if no errors found | ||
# Exit 1 if errors were found | ||
# | ||
# Requires | ||
# - php | ||
# | ||
# Arguments | ||
# - None | ||
|
||
# Echo Colors | ||
msg_color_magenta='\e[1;35m' | ||
msg_color_yellow='\e[0;33m' | ||
msg_color_none='\e[0m' # No Color | ||
|
||
# Loop through the list of paths to run php codesniffer against | ||
echo -en "${msg_color_yellow}Begin PHP Codesniffer ...${msg_color_none} \n" | ||
phpcs_local_exec="phpcs.phar" | ||
phpcs_command="php $phpcs_local_exec" | ||
|
||
# Check vendor/bin/phpunit | ||
phpcs_vendor_command="vendor/bin/phpcs" | ||
phpcs_global_command="phpcs" | ||
if [ -f "$phpcs_vendor_command" ]; then | ||
phpcs_command=$phpcs_vendor_command | ||
else | ||
if hash phpcs 2>/dev/null; then | ||
phpcs_command=$phpcs_global_command | ||
else | ||
if [ -f "$phpcs_local_exec" ]; then | ||
phpcs_command=$phpcs_command | ||
else | ||
echo "No valid PHP Codesniffer executable found! Please have one available as either $phpcs_vendor_command, $phpcs_global_command or $phpcs_local_exec" | ||
exit 1 | ||
fi | ||
fi | ||
fi | ||
|
||
phpcs_files_to_check="${@:2}" | ||
phpcs_args=$1 | ||
# Without this escape field, the parameters would break if there was a comma in it | ||
escape_comma="/," | ||
phpcs_args_parsed="${phpcs_args:escape_comma:,}" | ||
phpcs_command="$phpcs_command $phpcs_args_parsed $phpcs_files_to_check" | ||
|
||
echo "Running command $phpcs_command" | ||
command_result=`eval $phpcs_command` | ||
if [[ $command_result =~ ERROR ]] | ||
then | ||
echo -en "${msg_color_magenta}Errors detected by PHP CodeSniffer ... ${msg_color_none} \n" | ||
echo "$command_result" | ||
exit 1 | ||
fi | ||
|
||
exit 0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,76 @@ | ||
#!/bin/bash | ||
|
||
# Bash PHP Linter for Pre-commits | ||
# | ||
# Exit 0 if no errors found | ||
# Exit 1 if errors were found | ||
# | ||
# Requires | ||
# - php | ||
# | ||
# Arguments | ||
# -s : When to stop checking for errors | ||
# all : Default. Will check ALL given files until there isn't anymore | ||
# first : Will stop checking when it encounters the first file that has an error | ||
# | ||
# Example | ||
# -s first | ||
# -s all | ||
|
||
# Check Flags - denotes if we should check all files or stop at the first error file | ||
check_args_flag_all='all' | ||
check_args_flag_first='first' | ||
check_all=true | ||
|
||
# Echo Colors | ||
msg_color_magenta='\e[1;35m' | ||
msg_color_yellow='\e[0;33m' | ||
msg_color_none='\e[0m' # No Color | ||
|
||
# Where to stop looking for file paths in the argument list | ||
arg_lookup_start=1 | ||
|
||
# Flag to denote if a PHP error was found | ||
php_errors_found=false | ||
|
||
# Figure out if options were passed | ||
while getopts ":s:" optname | ||
do | ||
case "$optname" in | ||
"s") | ||
arg_lookup_start=2 | ||
if [ $OPTARG == $check_args_flag_first ]; then | ||
check_all=false | ||
elif [ $OPTARG == $check_args_flag_all ]; then | ||
check_all=true | ||
else | ||
check_all=true | ||
fi | ||
;; | ||
esac | ||
done | ||
|
||
# Loop through the list of paths to run php lint against | ||
echo -en "${msg_color_yellow}Begin PHP Linter ...${msg_color_none} \n" | ||
|
||
parse_error_count=0 | ||
for path in ${*:$arg_lookup_start} | ||
do | ||
php -l "$path" 1> /dev/null | ||
if [ $? -ne 0 ]; then | ||
# echo "PHP Parse errors were detected" >&2 | ||
parse_error_count=$[$parse_error_count +1] | ||
php_errors_found=true | ||
if [ "$check_all" = false ]; then | ||
echo "Stopping at the first file with PHP Parse errors" | ||
exit 1 | ||
fi | ||
fi | ||
done; | ||
|
||
if [ "$php_errors_found" = true ]; then | ||
echo -en "${msg_color_magenta}$parse_error_count${msg_color_none} ${msg_color_yellow}PHP Parse error(s) were found!${msg_color_none} \n" | ||
exit 1 | ||
fi | ||
|
||
exit 0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
#!/bin/bash | ||
|
||
# Bash PHP Unit Task Runner | ||
# | ||
# Exit 0 if no errors found | ||
# Exit 1 if errors were found | ||
# | ||
# Requires | ||
# - php | ||
# | ||
# Arguments | ||
# - None | ||
|
||
# Echo Colors | ||
msg_color_magenta='\e[1;35m' | ||
msg_color_yellow='\e[0;33m' | ||
msg_color_none='\e[0m' # No Color | ||
|
||
# Loop through the list of paths to run php lint against | ||
echo -en "${msg_color_yellow}Begin PHP Unit Task Runner ...${msg_color_none} \n" | ||
|
||
phpunit_local_exec="phpunit.phar" | ||
phpunit_command="php $phpunit_local_exec" | ||
|
||
# Check vendor/bin/phpunit | ||
phpunit_vendor_command="vendor/bin/phpunit" | ||
phpunit_global_command="phpunit" | ||
if [ -f "$phpunit_vendor_command" ]; then | ||
phpunit_command=$phpunit_vendor_command | ||
else | ||
if hash phpunit 2>/dev/null; then | ||
phpunit_command=$phpunit_global_command | ||
else | ||
if [ -f "$phpunit_local_exec" ]; then | ||
phpunit_command=$phpunit_command | ||
else | ||
echo "No valid PHP Unit executable found! Please have one available as either $phpunit_vendor_command, $phpunit_global_command or $phpunit_local_exec" | ||
exit 1 | ||
fi | ||
fi | ||
fi | ||
|
||
echo "Running command $phpunit_command" | ||
command_result=`eval $phpunit_command` | ||
if [[ $command_result =~ FAILURES ]] | ||
then | ||
echo "Failures detected in unit tests..." | ||
echo "$command_result" | ||
exit 1 | ||
fi | ||
exit 0 |