Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding simple support for youtube playlists #34

Closed
wants to merge 2 commits into from

Conversation

drhoet
Copy link

@drhoet drhoet commented Dec 21, 2015

Adding simple support for youtube playlist URLs

function sendYouTube(ytid, playhost) {
var url = 'plugin://plugin.video.youtube/?action=play_video&videoid=' + ytid;
function sendYouTubeVideo(ytid, playhost) {
var url = 'plugin://plugin.video.youtube/play/?video_id=' + ytid;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will also address #29 👍

@dirkjanm
Copy link
Owner

This looks good, work on playlists is being done in the playlists feature branch, I'm not sure yet when that one will be finished since it requires quite some thinking about what to do with the several buttons we're getting.
Could you make your pull request to that branch so I can merge it in already?

@drhoet drhoet mentioned this pull request Dec 28, 2015
@drhoet
Copy link
Author

drhoet commented Dec 28, 2015

See #35
There are however some other changes already going on that branch, e.g. the change of method name to parseUrl and the added call to plists.add_item();
I didn't immediately see how to merge it correctly ;-)

@dirkjanm
Copy link
Owner

Closing in favor of #35

@dirkjanm dirkjanm closed this Dec 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants