Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "UX: Hide inner site settings sidebar if admin sidebar enabled (#31047)" #31268

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

martin-brennan
Copy link
Contributor

@martin-brennan martin-brennan commented Feb 11, 2025

This reverts commit 91e9c1c.

After feedback, for now we are reverting this change. This is not
permanent, the settings sidebar will be removed again, after we:

  • Visually group the settings the same way as the sidebar does
    on All Settings
  • Add more settings pages to the main admin sidebar to cover the ~250
    settings not yet represented there

…#31047)"

This reverts commit 91e9c1c.

After feedback, for now we are reverting this change. This is not
permanent, the settings sidebar will be removed again, after we:

* Visually group the settings the same way as the sidebar does
  on All Settings
* Add more settings pages to the main admin sidebar to cover the ~250
  settings not yet represented there
@github-actions github-actions bot added the i18n PRs which update English locale files or i18n related code label Feb 11, 2025
@martin-brennan martin-brennan merged commit edd19bd into stable Feb 11, 2025
19 checks passed
@martin-brennan martin-brennan deleted the ux/revert-admin-site-setting-sidebar branch February 11, 2025 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n PRs which update English locale files or i18n related code
Development

Successfully merging this pull request may close these issues.

2 participants