New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct cross path for protobuf-runtime-scala #1648

Merged

Baccata merged 1 commit into series/0.18 from fix-proto-runtime-dep

Feb 11, 2025

Member

kubukoz commented Feb 9, 2025 •

edited

Loading

Currently it fails linking on my machine in JS land. Makes me wonder if protobuf is correctly tested on all platforms 🤔

PR Checklist (not all items are relevant to all PRs)

Added unit-tests (for runtime code)
Added bootstrapped code + smoke tests (when the rendering logic is modified)
Added build-plugins integration tests (when reflection loading is required at codegen-time)
Added alloy compliance tests (when simpleRestJson protocol behaviour is expanded/updated)
Updated dynamic module to match generated-code behaviour
Added documentation
Updated changelog


          Use correct cross path for protobuf-runtime-scala

649ddb6

Baccata approved these changes

View reviewed changes

Baccata merged commit 7cd62db into series/0.18

11 checks passed

Baccata deleted the fix-proto-runtime-dep branch

February 11, 2025 14:00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet