Use patterns instead of namespace literals for codegen #1649
+105
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baccata
reviewed
Feb 11, 2025
Comment on lines
29
to
30
| allowedNS: Option[Set[NamespacePattern]], | ||
| excludedNS: Option[Set[NamespacePattern]], |
There was a problem hiding this comment.
this change is not source compatible and CodegenArgs is very much part of the public API. Let's leave it as String please
There was a problem hiding this comment.
could've done an additional apply method with the new signature tbh
Baccata
previously approved these changes
Feb 12, 2025
msosnicki
commented
Feb 12, 2025
modules/codegen/test/src/smithy4s/codegen/internals/NamespacePatternSpec.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist (not all items are relevant to all PRs)
closes #1586